feat: add warn.redundantExpose for redundant @[expose]/@[no_expose] attributes#13359
Merged
Kha merged 5 commits intoleanprover:masterfrom Apr 27, 2026
Merged
feat: add warn.redundantExpose for redundant @[expose]/@[no_expose] attributes#13359Kha merged 5 commits intoleanprover:masterfrom
warn.redundantExpose for redundant @[expose]/@[no_expose] attributes#13359Kha merged 5 commits intoleanprover:masterfrom
Conversation
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 10, 2026
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 10, 2026
mathlib-lean-pr-testing
Bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
|
Mathlib CI status (docs):
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 13, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 13, 2026
|
Mathlib CI status (docs):
|
Kha
added
the
awaiting-mathlib
mathlib-lean-pr-testing
Bot
added
builds-mathlib
|
…pose]` attributes This PR adds a `linter.redundantExpose` option (default `true`) that warns when `@[expose]` or `@[no_expose]` attributes have no effect: - `@[expose]` on `abbrev` (always exposed) or non-Prop `instance` (always exposed) - `@[expose]` on a `def` inside an `@[expose] section` (already exposed by the section) - `@[expose]`/`@[no_expose]` in a non-`module` file (no module system) - `@[no_expose]` on a declaration that wouldn't be exposed by default Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Kha
changed the title
linter.redundantExpose for redundant @[expose]/@[no_expose] attributeswarn.redundantExpose for redundant @[expose]/@[no_expose] attributes
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 17, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 17, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 17, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 17, 2026
|
Mathlib CI status (docs):
|
|
Mathlib CI status (docs):
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 17, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Apr 17, 2026
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
linter.redundantExposeoption (defaulttrue) that warns when@[expose]or@[no_expose]attributes have no effect:@[expose]onabbrev(always exposed) or non-Propinstance(always exposed)@[expose]on adefinside an@[expose] section(already exposed by the section)@[expose]/@[no_expose]in a non-modulefile (no module system)@[no_expose]on a declaration that wouldn't be exposed by default